Repository navigation
fix(cli): resolve categories through the selected instance - #160
Open
TimeToBuildBob wants to merge 2 commits into
Open
TimeToBuildBob wants to merge 2 commits into
TimeToBuildBob wants to merge 2 commits into
Conversation
Git-Session-Id: 41c87248-7e00-4554-ae97-4d28ae19fb19
Git-Session-Id: 41c87248-7e00-4554-ae97-4d28ae19fb19
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryBoth CLI commands now load saved categories from the server the user selected.
Reviews (1) · Last reviewed commit: "fix(cli): resolve categories through the..." · Reviewed by Greptile |
Contributor
Author
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reportandcanonical.get_classes, retaining standalone construction and defaults for unset, empty or failed settings lookups.Closes #159
Reproduction and verification
Authoritative master c88cf12 reproduced three filing-probe failures: report settings targeted the second client, canonical never loaded settings, and canonical omitted the saved custom category. Initial repository tests: 12 failed / 4 passed; repaired and expanded tests: 40 passed.
make test: 162 passed (6.79s).make typecheck: clean, 31 source files.git diff --check: clean.No
make test-fasttarget exists here; used the bounded package test target (existing exclusions for live-server/interactive tests). Settings/transport are synthetic; actual CLI/query builders run. No private activity or remote server requests and no claim of live AQL classification.Scope / overlap
Inspected open PRs #138, #145, #147 and #158. #158 independently adds cache-name decorators in the same CLI; this patch changes imports/category lookup only and does not copy its decorators or change cache policy, timezone or output shape. Passing the selected client avoids reconstructing endpoint/auth/config state. Empty settings deliberately retain the existing default fallback rather than introducing new semantics.