Repository navigation
fix(gui): show bitmask usage once per parameter table - #2304
Closed
YoussGm3o8 wants to merge 1 commit into
Closed
YoussGm3o8 wants to merge 1 commit into
YoussGm3o8 wants to merge 1 commit into
Conversation
Inline component validation refreshes the parameter table when a dropdown opens. Reopening bitmask help on every refresh creates repeated modal windows that steal focus from the dropdown. Remember when a table has shown its bitmask help, including during batched rendering. Cover workflow and external-file tables and verify that ordinary choice parameters do not request bitmask help. Signed-off-by: YoussGm3o8 <youssefelkesti2005@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2302
Opening an inline component dropdown can refresh the parameter table several times. Each refresh opens bitmask usage help, creating repeated modal windows that steal focus from the dropdown.
Remember when a table has displayed its bitmask help. Apply the guard to immediate and batched rendering while preserving the saved popup preference. Add regression coverage for workflow and external-file tables, including ordinary choices that should not request bitmask help.
Checklist
git commit --signoff)Testing
The regression fails against upstream code and passes with the fix.
161 focused tests pass on Windows with Python 3.14.6.
Automated native Windows UI reproduction confirms that both receiver dropdowns open and selections update the derived parameters without repeated help.
Applicable pre-commit and pre-push checks pass.
Unit tests pass
Integration tests pass
Manual testing performed
Tested on flight controller hardware
The full repository suite and Linux/macOS were not tested for this change.