Repository navigation
Unify Constructed format selection in the lobby and deck editor - #12521
Merged
Merged
Conversation
One grouped Format dropdown replaces the Game Format list in the Constructed lobby and the deck editor. It lists the legality formats (Standard, Pauper and so on) alongside Commander, Oathbreaker, Brawl, Tiny Leaders, Momir Basic and MoJhoSto, under headings. A chosen legality format filters the deck lists and the editor's catalogue. With deck conformance on, the lobby checks every deck against it at start through the existing play-anyway prompt. A disabled combo box now draws its value in the normal text colour, so netplay guests can read the host's choice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MostCromulent
requested review from
Agetian,
kevlahnota,
tehdiplomat and
tool4ever
October 30, 2026 10:13
MostCromulent
marked this pull request as ready for review
October 30, 2026 10:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kevlahnota
approved these changes
Oct 30, 2026
Agetian
approved these changes
Oct 31, 2026
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Constructed lobby and the deck editor now have one Format dropdown. It lists legality formats (Standard, Pauper, Modern etc.) together with Commander, Oathbreaker, Brawl, Tiny Leaders, Momir Basic and MoJhoSto. Decks are checked against the selected legality format at match start.
Benefits
Implementation
FormatChoices(new, forge-gui) builds the grouped list for both platforms: Constructed, the format files fromgetFilterList()grouped by type, the Commander game types, and in the lobby only Momir Basic and MoJhoSto. Commander-subtype format files are skipped, because their game types cover them.GameLobby.getFormatChoiceandsetFormatChoicemap an entry to the applied variants plus a format. The format name is stored inGameLobbyData, so it travels with the existing lobby update.startGameaddsGameFormat.getDeckConformanceProblemresults to the existing legality warning, skipping generated decks and Limited.DeckManagerandCardManagergetsetRequiredFormat, which applies the existingDeckFormatFilterorCardFormatFilterand keeps it when filters are restored or reset. MobileDeckManagersets its existing Format filter widget instead.FormatChoices;CDeckEditorUI.selectFormatopens the Constructed editor for a legality format;ListHeading(new) rows in desktop and mobileFComboBoxdraw as group labels and cannot be selected; a disabled desktopFComboBoxdraws its value in dimmed text colour so netplay guests can read the host's choice; the now-unusedlblGameFormatis removed from all language files.🤖 Generated with Claude Code