Skip to content

fix: reject incomplete review history responses - #461

Open
huang47 wants to merge 1 commit into
codex/cursor-label-shapefrom
codex/cursor-review-history-shape
Open

huang47 wants to merge 1 commit into
codex/cursor-label-shapefrom
codex/cursor-review-history-shape

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

An empty review list means no reviews were returned. A missing list or an unknown pagination flag does not mean that, so the reader now reports the response as incomplete rather than silently treating it as a complete history.

Motivation

Review counts and approval cleanup depend on a complete history. Incomplete API response shapes could previously be read as an empty or final page, hiding earlier or later reviews.

Provenance

  • Authored by: interactive session
  • Verified: Cursor review suite passed 1,768 tests, including missing and null review lists and missing or malformed pagination flags. Pin, agent-instruction and repository-literal checks passed. One read-only GraphQL response had an array of nodes and a boolean pagination flag.
  • Deviations: Current-head CI passed; CodeRabbit was skipped. No live failure was injected. The existing caller-specific behavior for a read error still applies; the default round cap remains fail-open unless opted into fail-closed handling.

Reviewer context

Summary

  • Reject missing or non-list review nodes and missing or non-boolean pagination flags before claiming the history is complete.
  • Keep valid empty arrays and normal pagination behavior.

Test plan

  • Verify malformed responses reach each consumer's existing read-error path.
  • Verify empty review lists and paginated responses still work.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 45b83a58-a64b-4d6a-9ba6-b7f631e7a808

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants