Skip to content

fix: stop strict review cap on unknown review fields - #462

Open
huang47 wants to merge 2 commits into
codex/cursor-review-history-shapefrom
codex/cursor-review-fields
Open

huang47 wants to merge 2 commits into
codex/cursor-review-history-shapefrom
codex/cursor-review-fields

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

When a review might belong to the automated reviewer but its author, body or necessary submission time is missing, strict round counting now stops instead of treating it as no review.

Summary

  • Validate fields needed to identify a possible review round and its reset window in strict mode.
  • Keep legacy behavior and allow an unmarked review with a deleted author.

Reviewer context

  • Stack order: 7/7, based on #461.
  • A missing author on a marked review or a missing body with an unknown author is ambiguous and stops strict counting. After delivery, the workflow attempts human handoff and reports failure.

Provenance

  • Authored by: interactive session.
  • Verified: 1,777 Cursor suite tests passed, including strict, legacy, deleted-author and after-delivery cases; workflow pin, agent integrity and repository literal checks passed. Agent integrity reported two existing warnings.
  • Deviations: Current-head CI passed; CodeRabbit was skipped. The malformed fields were simulated, not observed in a live GitHub response. Handoff and concurrent execution remain unverified. Nonempty malformed timestamps are not validated. Diagram hosting is pending.

Test plan

  • Verify strict counting stops on ambiguous review fields and attempts handoff after delivery.
  • Verify an unmarked review with a missing author and legacy callers retain their behavior.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8759dce1-8797-4bbd-ae7f-1bb316b817e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@huang47
huang47 marked this pull request as ready for review November 20, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants