Skip to content

fix(api): stop expected 4xx outcomes from opening error issues - #2709

Merged
Makisuo merged 4 commits into
mainfrom
triage/api-error-noise
Nov 16, 2026
Merged

Makisuo merged 4 commits into
mainfrom
triage/api-error-noise

test(saved-views): use effect String

82d47fe
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 16, 2026 in 2m 43s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Both behavior changes are pinned by new tests: the real-error bridge test and the tracer test that fails whenever the insert hits the unique index.
no findings · tests covered · risk medium · 1/1 new units observable

Stops three expected 4xx outcomes from exporting as Error spans: saved-view creates insert with ON CONFLICT DO NOTHING, renames check the name first, and the api's telemetry options anticipate McpOAuthProtocolError and TransitionConflictError. Safe to merge.

  • create inserts with onConflictDoNothing; no row back answers SavedViewNameTakenError
  • update reads for a name clash before writing, 23505 mapping kept as the race fallback
  • apiTelemetryOptions adds two backend tags to the anticipated 4xx set
  • Bridge and saved-views tests pin both behaviors
What was checked
  • SavedViewNameTakenError is already in the generated 4xx list (packages/domain/src/generated/anticipated-error-identifiers.ts:182), so the service span exports Ok
  • Every McpOAuthProtocolError site renders a 400 through oauthError/redirect; no server_error code exists
  • The rename clash query matches the unique index columns exactly and hits saved_views_owner_surface_name_unq
Observability coverage: 1 of 1 changes observable
Change Kind Observable Evidence
Rename name-clash SELECT in SavedViewsService.update database query yes Runs inside the existing SavedViewsService.update span through dbExecute (packages/backend/src/platform/db-execute.ts:59)

82d47fe · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.