Repository navigation
fix(api): stop expected 4xx outcomes from opening error issues #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+130
−18
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a842695
fix(api): stop expected 4xx outcomes from opening error issues
Makisuo 9aa3488
Merge remote-tracking branch 'origin/main' into triage/api-error-noise
Makisuo 7fcce0f
test(saved-views): a taken name fails no database span
Makisuo 82d47fe
test(saved-views): use effect String
Makisuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import type { WorkerTelemetryOptions } from "@maple/infra/worker-telemetry" | ||
|
|
||
| /** | ||
| * Backend errors the api always answers as a 4xx or absorbs, added to the domain's 4xx set so a | ||
| * span that fails only with one exports `Ok`: an OAuth client's bad request (rendered as an OAuth | ||
| * 400) and a guarded transition that lost its race (remapped to a 409 or caught as a no-op). | ||
| * Literals keep the backend classes off the init path; the bridge test holds them to the classes. | ||
| */ | ||
| export const API_ANTICIPATED_ERROR_IDENTIFIERS: ReadonlyArray<string> = [ | ||
| "@maple/backend/errors/McpOAuthProtocolError", | ||
| "@maple/backend/TransitionConflictError", | ||
| ] | ||
|
|
||
| export const apiTelemetryOptions: WorkerTelemetryOptions = { | ||
| serviceName: "maple-api", | ||
| anticipatedErrorIdentifiers: API_ANTICIPATED_ERROR_IDENTIFIERS, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
onConflictDoNothingon saved-view create is not pinned by any testF1 · Warning · tests
The duplicate-name tests (
SavedViewsService.test.ts:250,:252) only assert the 409 tag, which the removed 23505 mapping produced too. Dropping line 273 or the rename pre-check leaves every test green, so nothing catches the failedDatabaseErrorspan and its error issue coming back.🤖 Prompt to fix with an AI agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: new test runs the duplicate create and rename under a tracer and asserts only the SavedViewsService call spans fail. Verified it fails when onConflictDoNothing is removed.