Repository navigation
Conversation
A new Settings tab for Enterprise orgs: verify domains by DNS TXT record, connect a SAML or OIDC identity provider, require SSO with a confirm and a break-glass list, set up SCIM with a token shown once, rotate, pause or remove it, and map IdP groups to roles. Non-admins see it read-only; orgs without the Enterprise plan see a contact-sales notice. /lab/sso renders every state over fixtures. Docs: reference/single-sign-on.
This comment has been minimized.
This comment has been minimized.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
There was a problem hiding this comment.
Devin Review found 3 potential issues.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
… says why Connect is disabled - Without the plan, admins can still relax Require SSO, pause or remove SCIM, remove the connection and break-glass members; setting up stays gated. - A failed member list loads again on retry, revisit and reopening the break-glass dialog. - Add member waits for a connection; an empty picker says whether nobody is on the SSO domains or everyone already has access. - The connection dialog names what the draft is missing next to its submit.
🍁 Maple PR previewWarning The latest preview deployment did not complete. The Alchemy deploy outcome was Commit |
This comment has been minimized.
This comment has been minimized.
…e eligibility The member list loads every page instead of the first 100, and the picker no longer filters on the primary email: any verified address on the SSO domains qualifies, and the API's refusal names the reason.
Maple review🟢 Confidence 10/10 · safe to merge. The pagination fix is verified and the tab is pinned by scene tests; the earlier read-only note still keys only on Adds the SSO & SCIM settings tab (domains, identity provider, enforcement, break-glass members, SCIM token and role mappings) built from the kit, plus its
Still open from earlier reviews
Fixed since the last review
|
|
@maple-review-bot won't fix F4: the tab derives |
|
Checked You're right about the derivation and about writes being safe — I'm not disputing either. But F4 was only about the message, and that half still holds, so I'm leaving it open. The other tabs that derive // apps/web/src/page/settings/view.ts:259
const ROLE_GATED_TABS: ReadonlySet<SettingsTab> = new Set([
"general", "members", "billing", "keys", "automation",
])
...(model.canManage ? [] : [adminOnlyNote(h, ["Only admins can change SSO and SCIM settings."])]),That tells an admin they lack the role rather than that the role couldn't be read — and the page note that would have said the latter is suppressed by |
|
@maple-review-bot fair, fixed in f3c10df: |
|
Note ⏳ Maple is reviewing this pull request at |
|
Checked the head: The tab's own note is unchanged though. ...(model.canManage ? [] : [adminOnlyNote(h, ["Only admins can change SSO and SCIM settings."])]),So the admin reads "editing is off, we couldn't confirm your role" and immediately below it "only admins can change SSO" — the claim F4 was about. The other role-gated tabs avoid exactly this: general, members and billing pass The smallest fix is the same plumbing: add |
Stack: 1/2 #2721 (API, tables, webhook) > 2/2 (this PR)
What
?tab=sso, under Access): domains with their TXT record and Verify, connect or edit a SAML/OIDC identity provider (only verified domains offered), the values to paste into the IdP, a Require SSO switch with a confirm, break-glass members (picker limited to members on the SSO domains), SCIM set-up with the token shown once in a dialog and cleared from state on close, pause/resume, rotate (confirm), remove, and role mapping rows (IdP group to Admin, Engineer, Member or Analyst) with reorder, save and discard./lab/ssorenders every state over fixtures (?state=not-entitled|empty|pending|connected|enforce|configured|token|member).apps/landing/src/content/docs/reference/single-sign-on.md(setup, SCIM for Okta and Entra ID, role mapping, deprovisioning, troubleshooting).Built from the kit only; no new kit components or icons.
Screenshots (
/lab/sso)Verification
sso.scene.test.ts(10): not-entitled notice, empty state, read-only member, TXT record shown, SAML form checked before submit, enforce confirm, token revealed once and cleared on close, role mapping save payload.src/lab/registry.test.tspass; web typecheck clean;oxlint -c .oxlintrc.effect.jsonand plainoxlintclean on every touched file;ui:patterns:checkOK.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.