Skip to content

feat(web): SSO & SCIM settings tab and customer docs - #2722

Open
Makisuo wants to merge 14 commits into
t3/enterprise-sso-scimfrom
t3/enterprise-sso-scim-web
Open

Makisuo wants to merge 14 commits into
t3/enterprise-sso-scimfrom
t3/enterprise-sso-scim-web

fix(web): SSO tab's admin-only note waits for a known role

f907409
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 16, 2026 in 51s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The four files changed since the last review only thread isKnownMember into the SSO view, pinned by a scene test that fails if the admin-only note returns.
no findings · tests covered · risk medium

Adds the SSO & SCIM settings tab (?tab=sso), a /lab/sso fixture lab and customer docs. The four commits since the last review only make the tab's admin-only note wait for a known role, and they do; safe to merge.

  • SsoView.view takes isKnownMember, so the admin-only note waits for a known role
  • sso joins ROLE_GATED_TABS, so an unconfirmed role gets the page banner instead
  • The rotate-token confirm now states the old token's grace period

Before merge

  • Manual · Merge #2721 first: the tab reads and writes the enterprise SSO endpoints it adds
What was checked
  • Both mount sites pass the new input: settings/view.ts:206 and sso-lab.ts:238
  • isKnownMember is Clerk plus a settled session (update.ts:76), so a loading session hides the note too
  • The new scene test fails if the note renders under an unconfirmed role (sso.scene.test.ts:309)

f907409 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.