Skip to content

fix(landing): markdown for the uptime-setup feature section - #2723

Merged
Makisuo merged 2 commits into
mainfrom
fix/landing-uptime-setup-markdown
Nov 16, 2026
Merged

Makisuo merged 2 commits into
mainfrom
fix/landing-uptime-setup-markdown

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Main's effect-lint fails since faee2ea: #2716 and #2717 each passed on their own, but together the uptime feature page lists an uptime-setup section that sectionMarkdown in apps/landing/src/lib/feature-sections.ts has no case for (Switch is not exhaustive. Cases not matched: "uptime-setup"). Every open PR's lint job fails on it.

This adds the case. It renders the section's title, lede and three facts the same way the page's UptimeSetup.astro does, plus its two docs links.

Verified: oxlint -c .oxlintrc.effect.json apps/landing/src/lib/feature-sections.ts is clean after bun run sync:i18n.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

#2716 and #2717 each passed alone; together the uptime page lists an uptime-setup
section that sectionMarkdown has no case for, which fails effect-lint on main.
@maple-review-bot

This comment has been minimized.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 070d9c77-6ec8-4f52-84bd-09f3defde0dd
Commits

Reviewing files that changed from the base of the PR and between faee2ea and 62bfb7f.

Files selected for processing: 3

  • apps/landing/src/components/page/sections/UptimeSetup.astro
  • apps/landing/src/lib/feature-sections.test.ts
  • apps/landing/src/lib/feature-sections.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@maple-review-bot maple-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 inline note from Maple's review. The score and summary are in the review comment above.

The page and its markdown now share UPTIME_SETUP_WAYS, so the lede's promise holds in both.
@maple-review-bot

maple-review-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. The added switch case follows the existing k8s-install pattern, all message keys exist, and a new test pins the three snippets plus the docs link.
no findings · tests covered · risk low

Adds the missing uptime-setup case to sectionMarkdown and moves the three snippets into UPTIME_SETUP_WAYS, shared by the .md twin and UptimeSetup.astro so the two cannot drift. Safe to merge.

  • sectionMarkdown gains an exhaustive uptime-setup case, fixing the effect-lint failure
  • UPTIME_SETUP_WAYS holds the agent, Terraform and REST snippets once
  • UptimeSetup.astro renders those ways from the shared constant
  • New test pins each snippet's heading and fenced block in the markdown twin

62bfb7f · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@Makisuo
Makisuo merged commit b374105 into main Nov 16, 2026
24 checks passed
@Makisuo
Makisuo deleted the fix/landing-uptime-setup-markdown branch November 16, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant