Skip to content

fix(landing): markdown for the uptime-setup feature section - #2723

Merged
Makisuo merged 2 commits into
mainfrom
fix/landing-uptime-setup-markdown
Nov 16, 2026
Merged

Makisuo merged 2 commits into
mainfrom
fix/landing-uptime-setup-markdown

fix(landing): print the uptime check three ways in the .md twin

62bfb7f
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 16, 2026 in 46s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The added switch case follows the existing k8s-install pattern, all message keys exist, and a new test pins the three snippets plus the docs link.
no findings · tests covered · risk low

Adds the missing uptime-setup case to sectionMarkdown and moves the three snippets into UPTIME_SETUP_WAYS, shared by the .md twin and UptimeSetup.astro so the two cannot drift. Safe to merge.

  • sectionMarkdown gains an exhaustive uptime-setup case, fixing the effect-lint failure
  • UPTIME_SETUP_WAYS holds the agent, Terraform and REST snippets once
  • UptimeSetup.astro renders those ways from the shared constant
  • New test pins each snippet's heading and fenced block in the markdown twin
What was checked
  • All uptime_setup_* message keys the case reads exist in apps/landing/messages/en.json:1477-1490
  • blocks/fence in page-markdown.ts:32,110 produce exactly the shape the new test asserts
  • Shared-constant pattern matches K8sInstall.astro:13 and ProductEventsSources.astro:17

62bfb7f · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.