Repository navigation
Conversation
…hows them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vbA3j9hMDhLiYyTkHLpH8 Co-Authored-By: bracyw <138251570+bracyw@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
TheJeffreyKuo
left a comment
There was a problem hiding this comment.
Looks good, a problem caught and a question
| this.subscribeToBetaCellInfo(); | ||
| } | ||
| let released = false; | ||
| return () => { |
There was a problem hiding this comment.
Keep cell readings across BMS page switches, as before; delay this teardown by TOPIC_SWEEP_MS
| * each topic's latest value, so a quick page switch keeps the readings); the last release drops | ||
| * them and clears the readings, which would otherwise go stale. | ||
| */ | ||
| updateCellInfo = (): (() => void) => { |
There was a problem hiding this comment.
Should the segment page subscribe only its own segment's cells?
Changes
Stacked on #1012. CellService no longer subscribes to the ~720 BMS cell topics app-wide at startup. Components that show cell data call updateCellInfo, which now returns a release: the segment heatmap while it exists, and the Cell Comparison panel while it's open (it's an overlay that can outlive the BMS pages). On the last release, readings are cleared so nothing shows stale values.
Diagram
Testing
Demo
Switching pages: 0:00 Charging (23 topics) · 0:05 Open BMS (its topics added at once in one list, then Charging's dropped at the next sweep: 751 topics, ~700 msgs/s) · 0:13 Back to Charging (its topics added at once; BMS's stop at the next sweep, within 2.5 s)
selective-delivery.mp4
Reconnect: 0:00 BMS live · 0:05 Connection drops · 0:10 Reconnected (the handshake carries the page's 751 topics, no reload)
reconnect.mp4
Notes
Checklist
Closes #995