Skip to content

Update logback version - #25465

Open
rkamalakannan wants to merge 3 commits into
OpenAPITools:masterfrom
rkamalakannan:master
Open

rkamalakannan wants to merge 3 commits into
OpenAPITools:masterfrom
rkamalakannan:master

Conversation

@rkamalakannan

@rkamalakannan rkamalakannan commented Oct 29, 2026 •

Copy link
Copy Markdown

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Updates logback-classic from 1.2.13 to 1.5.19 in the test scope of modules/openapi-generator/pom.xml and pins slf4j.version to 2.0.16 in the root pom.xml to match the logback 1.5.x requirement. The change stays within test-scoped usage, so it doesn't affect runtime dependencies.

Written for commit 6803d19. Summary will update on new commits.

View guided diff

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/pom.xml">

<violation number="1" location="modules/openapi-generator/pom.xml:323">
P1: This upgrade leaves the module on SLF4J 1.7.36 while Logback 1.5.19 requires the SLF4J 2.x provider API. The test classpath therefore selects the existing 1.7 `slf4j-simple` binding, and tests that cast `LoggerFactory` results to Logback loggers fail; upgrade the SLF4J dependencies together or retain a Logback 1.2.x version.</violation>
</file>

Reply to a comment to ask cubic a question or push back. It learns from your replies.

View guided diff | Re-trigger cubic

<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.2.13</version>
<version>1.5.19</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: This upgrade leaves the module on SLF4J 1.7.36 while Logback 1.5.19 requires the SLF4J 2.x provider API. The test classpath therefore selects the existing 1.7 slf4j-simple binding, and tests that cast LoggerFactory results to Logback loggers fail; upgrade the SLF4J dependencies together or retain a Logback 1.2.x version.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At modules/openapi-generator/pom.xml, line 323:

<comment>This upgrade leaves the module on SLF4J 1.7.36 while Logback 1.5.19 requires the SLF4J 2.x provider API. The test classpath therefore selects the existing 1.7 `slf4j-simple` binding, and tests that cast `LoggerFactory` results to Logback loggers fail; upgrade the SLF4J dependencies together or retain a Logback 1.2.x version.</comment>

<file context>
@@ -320,7 +320,7 @@
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
-            <version>1.2.13</version>
+            <version>1.5.19</version>
             <scope>test</scope>
         </dependency>
</file context>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant