Skip to content

Update logback version #25465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkamalakannan wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −1
Open

Update logback version #25465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a956a3d
Update pom.xml
rkamalakannan Oct 29, 2026
137b46d
Merge pull request #1 from rkamalakannan/rkamalakannan-patch-1
rkamalakannan Oct 29, 2026
6803d19
Added slf4j.version as 2.0.16 to the root
rkamalakannan Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.2.13</version>
<version>1.5.19</version>

@cubic-dev-ai cubic-dev-ai Bot Oct 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: This upgrade leaves the module on SLF4J 1.7.36 while Logback 1.5.19 requires the SLF4J 2.x provider API. The test classpath therefore selects the existing 1.7 slf4j-simple binding, and tests that cast LoggerFactory results to Logback loggers fail; upgrade the SLF4J dependencies together or retain a Logback 1.2.x version.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At modules/openapi-generator/pom.xml, line 323:

<comment>This upgrade leaves the module on SLF4J 1.7.36 while Logback 1.5.19 requires the SLF4J 2.x provider API. The test classpath therefore selects the existing 1.7 `slf4j-simple` binding, and tests that cast `LoggerFactory` results to Logback loggers fail; upgrade the SLF4J dependencies together or retain a Logback 1.2.x version.</comment>

<file context>
@@ -320,7 +320,7 @@
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
-            <version>1.2.13</version>
+            <version>1.5.19</version>
             <scope>test</scope>
         </dependency>
</file context>

<scope>test</scope>
</dependency>
<dependency>
Expand Down
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
<distribution>repo</distribution>
</license>
</licenses>
<properties>
<slf4j.version>2.0.16</slf4j.version>
</properties>
<build>
<sourceDirectory>src/main/java</sourceDirectory>
<outputDirectory>target/classes</outputDirectory>
Expand Down
Loading