Repository navigation
hi3516cv6xx_ultimate_sip-k662c6s: add the IMX662 module - #226
Conversation
A Hi3516CV610 + IMX662 module with 16 MB NOR. The IR-cut, lamp and button pins come from its stock firmware; the sensor is named so the first boot skips the probe. Not yet run on a camera.
PR Summary by QodoAdd SIP K662C6S IMX662 camera configuration
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
The built image still carried the GC4023 profile and the CV2003, GC4023, GC4653, MIS20S1 and VS4388 tuning files, none of which this IMX662 module can use.
|
Reviewed against firmware One fix pushed to the branch ( Checked and fine: the defconfig matches firmware's, The four hardware checks are still open; this merge doesn't close them. |
Adds the SIP-K662C6S, a Hi3516CV610 + Sony IMX662 module with 16 MB NOR (OpenIPC/defib#148, OpenIPC/u-boot#71), as
hi3516cv6xx_ultimate_sip-k662c6s.Not run on a camera. Marked ready only so CI builds the first image to test; the checks below are still open.
What is in it
hi3516cv6xx_ultimate. There is no Wi-Fi driver: the stock config hasWIFI_TYPE = 0.customizer.sh:fw_setenv sensor imx662, because ipcinfo's IMX662 check is untested and this skips the probe at first boot. Also the upgrade URL, the IR-cut and lamp pins, andlightMonitor.gpio.conf: the pin map below.Pins
From a stock dump of this module (firmware
22.010.30.6_MAIN_V46(260616),xipc). That binary serves several products, so not every pin below is known to be connected here.0x11130054,0x111300500x111300380x1113003cgpio.confonly0x111300400x111300040x11130030Stock decides day and night from exposure, so no light sensor pin is set.
reset-buttonis deliberately not enabled. If pin 10 turns out not to be wired on this module, a floating input could read as a held button, and that daemon can factory-reset.There is no
muxes.sh. It runs at S30, andopen_sys_configloads at S70 and sets0x11130050/54to I2C2 (0x1133), so a pad write there would not last. That makes the first check below the one that matters.To check on a K662C6S
ipctool reginfoshows[GPIO7_4]on0x11130054and[GPIO7_5]on0x11130050. If those pads are still on I2C2, the filter will not move and this device needs a pad write after S70.en/ircut-filter.md. The 60/61 order is untested; swap them in both files if it reports "wired backwards".backlightInverton.spi nor register fail!.The IMX662 3DNR profile is separate, in OpenIPC/firmware#2776. This device does not need it to build, and keeps it when it lands.
Evidence
No board output. Offline only: