Repository navigation
fix(spec): an internal grouped sum onto a sparse key no longer warns of a dense grid - #1192
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
4 of 5 tasks
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
Changes proposed in this Pull Request
Model.from_specon a sparse model warned that grouping by[<key>, <dim>]makes a dense grid and to passobserved=True. The warning came from linopy itself, not from the user's spec:atread along its own key dimension (_at_by_rows) goes throughgrouped_sum, which groups the sparse rows and then reindexes onto the full key. The dense grid is the intended result there, andobserved=Truewould break the followingreindex(onto).grouped_sumnow ignores this one warning around its internalgroupby(...).sum(). A user's owngroupbystill warns.Seen in PyPSA (carbon management example,
Link × port):A regression test calls
grouped_sumon a sparse and a dense expression with warnings as errors and checks both agree. It fails without the fix.Checklist
AGENTS.md).doc.doc/release-notes.mdof the upcoming release is included.