Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the shared Starlight installer and workflow updates.
No open issues 🎉
What changed in this PR
Restores .star builds by replacing the npm Starlight installation with a pinned Millennium source revision that supports source provenance and production signing.
Changes:
- Adds a shared installer using
cargo install --lockedwith an immutable source revision. - Updates PR and production workflows to set up Rust and use the installer for
.starbuilds, leaving other build formats unchanged.
| File | Description |
|---|---|
scripts/build/install-starlight.sh |
Installs pinned Starlight with its Cargo lockfile and adds it to the workflow PATH. |
.github/workflows/pr.yml |
Sets up Rust and uses the shared installer for PR .star builds. |
.github/workflows/ci.yml |
Sets up Rust and uses the shared installer for production .star builds. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.starbuilds blocked by npm 1.1.6 rejecting--source-commitand lackingsignRefs tyvsmith/steam-native-notifications#56