Skip to content

fix(build): pin starlight with provenance and signing support #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyvsmith wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −2
Open

fix(build): pin starlight with provenance and signing support #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,13 @@ jobs:
name: build-scripts
path: scripts/build/

- name: Set up Rust
if: steps.format.outputs.format == 'star'
uses: dtolnay/rust-toolchain@stable

- name: Install starlight
if: steps.format.outputs.format == 'star'
run: npm install -g @steambrew/starlight@${{ vars.STARLIGHT_VERSION }}
run: bash ./scripts/build/install-starlight.sh

- name: Install pnpm
if: steps.format.outputs.format != 'star'
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,13 @@ jobs:
with:
node-version: "20"

- name: Set up Rust
if: steps.format.outputs.format == 'star'
uses: dtolnay/rust-toolchain@stable

- name: Install starlight
if: steps.format.outputs.format == 'star'
run: npm install -g @steambrew/starlight@${{ vars.STARLIGHT_VERSION }}
run: bash ./scripts/build/install-starlight.sh

- name: Install pnpm
if: steps.format.outputs.format != 'star'
Expand Down
11 changes: 11 additions & 0 deletions scripts/build/install-starlight.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/bin/bash
set -euo pipefail

# npm 1.1.6 predates source-commit metadata and the sign command.
# Keep PR builds and production signing on the same immutable compiler source.
cargo install starlight --locked \
--git https://github.com/SteamClientHomebrew/Millennium.git \
--rev d6a7822a43744b6290a0e059bdd032d9b9a2ec94 \
--root "$RUNNER_TEMP/starlight"

echo "$RUNNER_TEMP/starlight/bin" >> "$GITHUB_PATH"
Loading