test(solid-query/suspense): replace the 'TODO(lukemurray)' comments with notes explaining why the state counts differ from react by sukvvon · Pull Request #12300 · TanStack/query

sukvvon · 2026-10-23T08:51:09Z

🎯 Changes

In the should return the correct states for a successful infinite query test, the two TODO(lukemurray) comments describe an expected difference from react rather than remaining work: Solid records the pending state before suspending, since suspense occurs when data is read.

Replace them with plain notes that keep the explanation without the author tag.
Remove the oxlint-disable-next-line cspell/spellchecker comments that were only needed for the author tag.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

…ith notes explaining why the state counts differ from react

changeset-bot · 2026-10-23T08:51:18Z

⚠️ No Changeset found

Latest commit: bd87214

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-10-23T08:51:19Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/solid-query-suspense-replace-todo-with-note
File: .coderabbit.yaml
Commit: bd87214
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: ce34bd83-a708-4dbd-9de8-a497ba9ec7fd

📥 Commits

Reviewing files that changed from the base of the PR and between 6580131 and bd87214.

📒 Files selected for processing: 1

packages/solid-query/src/__tests__/suspense.test.tsx

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-10-23T08:51:36Z

View your CI Pipeline Execution ↗ for commit bd87214

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 10s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	5s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 08:54:31 UTC

github-actions · 2026-10-23T08:52:04Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-10-23T08:53:38Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12300

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12300

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12300

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12300

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12300

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12300

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12300

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12300

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12300

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12300

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12300

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12300

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12300

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12300

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12300

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12300

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12300

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12300

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12300

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12300

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12300

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12300

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12300

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12300

commit: bd87214

github-actions · 2026-10-23T08:53:50Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(solid-query/suspense): replace the 'TODO(lukemurray)' comments w…

bd87214

…ith notes explaining why the state counts differ from react

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit 0ab7c5f into main Oct 23, 2026
9 checks passed

sukvvon deleted the test/solid-query-suspense-replace-todo-with-note branch October 23, 2026 08:58

Navigation Menu

Repository navigation

test(solid-query/suspense): replace the 'TODO(lukemurray)' comments with notes explaining why the state counts differ from react - #12300

test(solid-query/suspense): replace the 'TODO(lukemurray)' comments with notes explaining why the state counts differ from react#12300
sukvvon merged 1 commit into
mainfrom
test/solid-query-suspense-replace-todo-with-note

sukvvon commented Oct 23, 2026

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Review limit reached

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Review limit reached

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading