You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(build): Remove the Wine and widl install step from MinGW-w64 jobs - #3675
The MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, which compiled the browser IDL files. #3691 removed the embedded browser and its IDL files, so nothing uses widl anymore.
This removes the "Install Wine and widl" step. The MinGW-w64 jobs no longer download from the WineHQ servers and finish faster.
AI USE
I used Claude Code to make the change. I checked it myself.
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The MinGW build workflow now installs wine64-tools without recommended packages. Its step name and comment describe the use of widl for IDL compilation.
Changes
MinGW workflow tool installation
Layer / File(s)
Summary
Install widl in the MinGW workflow .github/workflows/reusable-build-mingw.yml
Replaces WineHQ repository setup and Wine package installation with wine64-tools installation without recommended packages. The step comment describes widl’s IDL compilation purpose and package dependencies.
The workflow now installs widl from Ubuntu's wine64-tools package, which matches the existing CMake lookup and drops the WineHQ repository setup. No concrete merge-blocking risk remains.
Pre-merge checks: 3 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Title check
The title says the PR removes the Wine and widl install step from MinGW-w64 jobs. The raw summary and objectives describe a different change: the workflow still installs widl, but now from the Ubuntu …
Retitle the PR to describe the actual change, for example: "ci(build): Install widl from Ubuntu wine64-tools in MinGW-w64 jobs". This matches PR #3675's stated objective.
Passed checks: 3 passed
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description explains that the MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, and that the change removes the "Install Wine and widl" step because the embedded browser I…
Full details: Description check
Explanation
The description explains that the MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, and that the change removes the "Install Wine and widl" step because the embedded browser IDL files were removed in #3691. This matches the changeset, which replaces the WineHQ installation with wine64-tools and renames the step to "Install widl". The description is related to the changeset and is not off-topic.
Full details: Title check
Explanation
The title says the PR removes the Wine and widl install step from MinGW-w64 jobs. The raw summary and objectives describe a different change: the workflow still installs widl, but now from the Ubuntu wine64-tools package instead of the WineHQ repository. The title does not match the change. It describes removal of the step, while the step is kept and rewritten. The title is therefore misleading and does not describe the primary change.
Resolution
Retitle the PR to describe the actual change, for example: "ci(build): Install widl from Ubuntu wine64-tools in MinGW-w64 jobs". This matches PR #3675's stated objective.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 1df19845-1bc8-41ec-9bf4-bcae25e1ebb2
Commits
Reviewing files that changed from the base of the PR and between 855d76b and 5c7e11e.
Files selected for processing: 1
.github/workflows/reusable-build-mingw.yml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
.github/workflows/reusable-build-mingw.yml: 1
59-59: Trivial · Maintainability & Code Quality · Low value
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Quote $(nproc).
actionlint reports SC2046 for the unquoted -j$(nproc). The value is a single integer, so there is no practical failure. Use -j"$(nproc)" to clear the warning.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
OmarAglan
changed the title
ci(build): Install widl from mingw-w64-tools instead of Wine in MinGW-w64 jobs
ci(build): Install widl from the Ubuntu Wine packages instead of the WineHQ repository in MinGW-w64 jobs
Nov 10, 2026
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Can you see about removing the BrowserEngine stuff? I think the game does not use it and it can probably be removed
Yes, it is unused. TheWebBrowser is never created (its initSubsystem is commented out), and the Webpages INI is only loaded from WebBrowser::init. Only DX8WebBrowser is still initialized in W3DDisplay and updated every frame, but nothing opens a browser. I will remove the browser in a separate PR. After that this PR only needs to remove the Wine and widl install.
OmarAglan
changed the title
ci(build): Install widl from the Ubuntu Wine packages instead of the WineHQ repository in MinGW-w64 jobs
ci(build): Remove the Wine and widl install step from MinGW-w64 jobs
Nov 19, 2026
Can you see about removing the BrowserEngine stuff? I think the game does not use it and it can probably be removed
its now removed, and supposed to have a faster build as we dropped the wdl from it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, which compiled the browser IDL files. #3691 removed the embedded browser and its IDL files, so nothing uses widl anymore.
This removes the "Install Wine and widl" step. The MinGW-w64 jobs no longer download from the WineHQ servers and finish faster.
AI USE
I used Claude Code to make the change. I checked it myself.