Skip to content

ci(build): Remove the Wine and widl install step from MinGW-w64 jobs - #3675

Open
OmarAglan wants to merge 1 commit into
TheSuperHackers:mainfrom
OmarAglan:ci/mingw-widl-from-mingw-w64-tools
Open

OmarAglan wants to merge 1 commit into
TheSuperHackers:mainfrom
OmarAglan:ci/mingw-widl-from-mingw-w64-tools

Conversation

@OmarAglan

@OmarAglan OmarAglan commented Nov 10, 2026 •

Copy link
Copy Markdown

The MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, which compiled the browser IDL files. #3691 removed the embedded browser and its IDL files, so nothing uses widl anymore.

This removes the "Install Wine and widl" step. The MinGW-w64 jobs no longer download from the WineHQ servers and finish faster.

AI USE

I used Claude Code to make the change. I checked it myself.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The MinGW build workflow now installs wine64-tools without recommended packages. Its step name and comment describe the use of widl for IDL compilation.

Changes

MinGW workflow tool installation

Layer / File(s) Summary
Install widl in the MinGW workflow
.github/workflows/reusable-build-mingw.yml
Replaces WineHQ repository setup and Wine package installation with wine64-tools installation without recommended packages. The step comment describes widl’s IDL compilation purpose and package dependencies.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: bobtista, xezon

Merge Risk: Minimal · up to 5c7e1

The workflow now installs widl from Ubuntu's wine64-tools package, which matches the existing CMake lookup and drops the WineHQ repository setup. No concrete merge-blocking risk remains.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Title check Warning The title says the PR removes the Wine and widl install step from MinGW-w64 jobs. The raw summary and objectives describe a different change: the workflow still installs widl, but now from the Ubuntu … Retitle the PR to describe the actual change, for example: "ci(build): Install widl from Ubuntu wine64-tools in MinGW-w64 jobs". This matches PR #3675's stated objective.
Passed Passed checks: 3 passed

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains that the MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, and that the change removes the "Install Wine and widl" step because the embedded browser I…
Full details: Description check

Explanation

The description explains that the MinGW-w64 jobs installed Wine from the WineHQ repository only to get widl, and that the change removes the "Install Wine and widl" step because the embedded browser IDL files were removed in #3691. This matches the changeset, which replaces the WineHQ installation with wine64-tools and renames the step to "Install widl". The description is related to the changeset and is not off-topic.

Full details: Title check

Explanation

The title says the PR removes the Wine and widl install step from MinGW-w64 jobs. The raw summary and objectives describe a different change: the workflow still installs widl, but now from the Ubuntu wine64-tools package instead of the WineHQ repository. The title does not match the change. It describes removal of the step, while the step is kept and rewritten. The title is therefore misleading and does not describe the primary change.

Resolution

Retitle the PR to describe the actual change, for example: "ci(build): Install widl from Ubuntu wine64-tools in MinGW-w64 jobs". This matches PR #3675's stated objective.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1df19845-1bc8-41ec-9bf4-bcae25e1ebb2
Commits

Reviewing files that changed from the base of the PR and between 855d76b and 5c7e11e.

Files selected for processing: 1

  • .github/workflows/reusable-build-mingw.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

.github/workflows/reusable-build-mingw.yml: 1

59-59: Trivial · Maintainability & Code Quality · Low value

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Quote $(nproc).

actionlint reports SC2046 for the unquoted -j$(nproc). The value is a single integer, so there is no practical failure. Use -j"$(nproc)" to clear the warning.

Proposed fix

-          cmake --build build/${{ inputs.preset }} --target ${{ inputs.game == 'Generals' && 'g_generals' || 'z_generals' }} -j$(nproc)
+          cmake --build build/${{ inputs.preset }} --target ${{ inputs.game == 'Generals' && 'g_generals' || 'z_generals' }} -j"$(nproc)"

Source: Linters/SAST tools

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1c65bdce-7afd-4b20-96ce-d58efb9f8cb3
Commits

Reviewing files that changed from the base of the PR and between 998f337 and 521805b.

Files selected for processing: 9

  • .github/workflows/ci.yml
  • .github/workflows/reusable-build-mingw.yml
  • Core/Libraries/Source/EABrowserDispatch/CMakeLists.txt
  • Core/Libraries/Source/EABrowserEngine/CMakeLists.txt
  • Core/Libraries/Source/WWVegas/WWDownload/CMakeLists.txt
  • Generals/Code/GameEngine/CMakeLists.txt
  • GeneralsMD/Code/GameEngine/CMakeLists.txt
  • cmake/mingw.cmake
  • cmake/widl.cmake

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@OmarAglan
OmarAglan force-pushed the ci/mingw-widl-from-mingw-w64-tools branch from 521805b to 7151ff8 Compare November 10, 2026 10:46
@OmarAglan OmarAglan changed the title ci(build): Install widl from mingw-w64-tools instead of Wine in MinGW-w64 jobs ci(build): Install widl from the Ubuntu Wine packages instead of the WineHQ repository in MinGW-w64 jobs Nov 10, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 03af697b-a658-4212-914d-6569d0f0b941
Commits

Reviewing files that changed from the base of the PR and between 998f337 and 7151ff8.

Files selected for processing: 6

  • .github/workflows/ci.yml
  • .github/workflows/reusable-build-mingw.yml
  • Core/Libraries/Source/WWVegas/WWDownload/CMakeLists.txt
  • Generals/Code/GameEngine/CMakeLists.txt
  • GeneralsMD/Code/GameEngine/CMakeLists.txt
  • cmake/mingw.cmake

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@OmarAglan
OmarAglan force-pushed the ci/mingw-widl-from-mingw-w64-tools branch from 7151ff8 to 2bb995a Compare November 12, 2026 09:30
@OmarAglan
OmarAglan force-pushed the ci/mingw-widl-from-mingw-w64-tools branch 2 times, most recently from 855d76b to 5c7e11e Compare November 15, 2026 09:32
@OmarAglan
OmarAglan marked this pull request as ready for review November 15, 2026 09:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T08:57:50.675559Z b2a6763 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The PR removes the unused WineHQ setup from MinGW-w64 builds while keeping Ubuntu 24.04.

  • MinGW builds no longer add the WineHQ repository.

No actionable issues found.

Reviews (2) · Last reviewed commit: "ci(build): Remove the Wine and widl inst..." · Reviewed by Greptile

@xezon

xezon commented Nov 15, 2026

Copy link
Copy Markdown

Can you see about removing the BrowserEngine stuff? I think the game does not use it and it can probably be removed

@OmarAglan

Copy link
Copy Markdown
Author

Can you see about removing the BrowserEngine stuff? I think the game does not use it and it can probably be removed

Yes, it is unused. TheWebBrowser is never created (its initSubsystem is commented out), and the Webpages INI is only loaded from WebBrowser::init. Only DX8WebBrowser is still initialized in W3DDisplay and updated every frame, but nothing opens a browser. I will remove the browser in a separate PR. After that this PR only needs to remove the Wine and widl install.

@OmarAglan
OmarAglan force-pushed the ci/mingw-widl-from-mingw-w64-tools branch from 5c7e11e to b2a6763 Compare November 19, 2026 08:56
@OmarAglan OmarAglan changed the title ci(build): Install widl from the Ubuntu Wine packages instead of the WineHQ repository in MinGW-w64 jobs ci(build): Remove the Wine and widl install step from MinGW-w64 jobs Nov 19, 2026
@OmarAglan

Copy link
Copy Markdown
Author

Can you see about removing the BrowserEngine stuff? I think the game does not use it and it can probably be removed

its now removed, and supposed to have a faster build as we dropped the wdl from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants