Skip to content

refactor: Remove unused embedded web browser - #3691

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
OmarAglan:refactor/remove-embedded-web-browser
Nov 18, 2026
Merged

xezon merged 1 commit into
TheSuperHackers:mainfrom
OmarAglan:refactor/remove-embedded-web-browser

Conversation

@OmarAglan

Copy link
Copy Markdown

This change removes the embedded web browser code. The game never creates a browser.

  • TheWebBrowser is never created. Its initSubsystem line was already commented out in both GameEngine.cpp.
  • WebBrowser::init is never called, so the WebpageURL INI blocks were never loaded.
  • DX8WebBrowser was still initialized in W3DDisplay (it loaded BrowserEngine.dll) and updated and rendered every frame, but no browser window was ever opened.

Removed:

  • EABrowserDispatch and EABrowserEngine (IDL files and their libraries), and cmake/widl.cmake
  • DX8WebBrowser, WebBrowser, FEBDispatch.h, W3DWebBrowser and INIWebpageURL.cpp
  • BrowserEngine.dll from both Run folders
  • comsupp_compat.h and the comsuppw link, which only the browser used
  • CComModule _Module and its Init/Term calls in GameEngine
  • the dead TheWebBrowser code in the WOL login and ladder menus. The terms of service are still read from TOS.txt, as before.
  • the BrowserDispatch.tlb type library in the Generals RTS.RC

With this change, MinGW builds no longer need widl, so the Wine install step in the MinGW CI job can be removed in #3675.

ATL is still used by PreRTS.h. Removing it is left for a follow-up.

Note: DX8WebBrowser::Initialize was the only place the game called CoInitialize. Nothing else in the game uses COM objects, but please check that the game still starts on Windows.

AI USE

I used Claude Code to find all the browser references, make the removal and build both games with MinGW-w64. I reviewed the changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T14:34:49.880678Z da1ba71 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change removes the embedded browser and its COM, IDL, rendering, and game-menu integrations from both game variants. The online login menu now displays terms from a language-specific text file. Browser-related build configuration and compatibility code are also removed.

Changes

Embedded browser removal

Layer / File(s) Summary
Engine interfaces and URL parsing
Core/GameEngine/..., Generals/Code/GameEngine/..., GeneralsMD/Code/GameEngine/...
The browser subsystem interfaces and implementation, URL INI parsing, engine factory methods, and browser URL pool entries are removed.
Renderer and device integration
Core/GameEngineDevice/..., Core/Libraries/Source/WWVegas/WW3D2/..., Generals/Code/GameEngineDevice/..., GeneralsMD/Code/GameEngineDevice/...
The DX8 browser wrapper, W3D browser adapters, browser display lifecycle calls, and related source-list entries are removed.
Online menu behavior
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/..., GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/...
The ladder screens no longer manage browser windows. The login menus load terms from the language-specific TOS.txt file and no longer manage a TOS browser window.
IDL and build support
CMakeLists.txt, cmake/..., Core/Libraries/..., Dependencies/Utility/..., Core/.gitignore, Generals/.gitignore, GeneralsMD/.gitignore, Generals/Code/Main/RTS.RC
Browser IDL files, IDL compiler configuration, browser library targets, COM compatibility code, and related generated-file references are removed.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Possibly related PRs

Suggested labels: Refactor

Suggested reviewers: xezon, bobtista

Merge Risk: Minimal · up to da1ba

The change removes unused embedded-browser code and build support, and the login menu now shows the terms of service from the language-specific text file. No concrete defect was found. Windows startup was not reported as tested, so confirm that the game launches before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Description check Passed The description states the purpose of the change: removing the embedded web browser code, which the game never opens. It lists the removed components, including EABrowserDispatch, EABrowserEngine, DX8…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title "refactor: Remove unused embedded web browser" matches the main change. The PR deletes the embedded WebBrowser, DX8WebBrowser, W3DWebBrowser, BrowserDispatch and BrowserEngine sources, and t…
Full details: Description check

Explanation

The description states the purpose of the change: removing the embedded web browser code, which the game never opens. It lists the removed components, including EABrowserDispatch, EABrowserEngine, DX8WebBrowser, W3DWebBrowser, and comsupp_compat.h. It also explains the menu and TOS.txt behavior and gives a note about COM initialization and Windows startup testing. It is directly related to the changeset.

Full details: Title check

Explanation

The title "refactor: Remove unused embedded web browser" matches the main change. The PR deletes the embedded WebBrowser, DX8WebBrowser, W3DWebBrowser, BrowserDispatch and BrowserEngine sources, and their build and menu references. The title is short, specific, and uses a conventional commit prefix. The PR objectives describe the same removal, so the title is fully related to the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e704653b-0b2f-45db-8952-27805f953009
Commits

Reviewing files that changed from the base of the PR and between e655cb2 and da1ba71.

Files ignored due to path filters: 2

  • Generals/Run/BrowserEngine.dll is excluded by !**/*.dll
  • GeneralsMD/Run/BrowserEngine.dll is excluded by !**/*.dll
Files selected for processing: 51

  • CMakeLists.txt
  • Core/.gitignore
  • Core/GameEngine/CMakeLists.txt
  • Core/GameEngine/Include/Common/INI.h
  • Core/GameEngine/Include/GameNetwork/WOLBrowser/FEBDispatch.h
  • Core/GameEngine/Include/GameNetwork/WOLBrowser/WebBrowser.h
  • Core/GameEngine/Source/Common/INI/INI.cpp
  • Core/GameEngine/Source/Common/INI/INIWebpageURL.cpp
  • Core/GameEngine/Source/Common/System/GameMemoryInitPools_Generals.inl
  • Core/GameEngine/Source/Common/System/GameMemoryInitPools_GeneralsMD.inl
  • Core/GameEngine/Source/GameNetwork/WOLBrowser/WebBrowser.cpp
  • Core/GameEngineDevice/CMakeLists.txt
  • Core/GameEngineDevice/Include/Win32Device/Common/Win32GameEngine.h
  • Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp
  • Core/Libraries/CMakeLists.txt
  • Core/Libraries/Source/EABrowserDispatch/BrowserDispatch.idl
  • Core/Libraries/Source/EABrowserDispatch/CMakeLists.txt
  • Core/Libraries/Source/EABrowserEngine/BrowserEngine.idl
  • Core/Libraries/Source/EABrowserEngine/CMakeLists.txt
  • Core/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
  • Core/Libraries/Source/WWVegas/WW3D2/dx8webbrowser.cpp
  • Core/Libraries/Source/WWVegas/WW3D2/dx8webbrowser.h
  • Core/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp
  • Dependencies/Utility/CMakeLists.txt
  • Dependencies/Utility/Utility/comsupp_compat.h
  • Generals/.gitignore
  • Generals/Code/GameEngine/CMakeLists.txt
  • Generals/Code/GameEngine/Include/Common/GameEngine.h
  • Generals/Code/GameEngine/Source/Common/GameEngine.cpp
  • Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLadderScreen.cpp
  • Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLoginMenu.cpp
  • Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLWelcomeMenu.cpp
  • Generals/Code/GameEngineDevice/CMakeLists.txt
  • Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DWebBrowser.h
  • Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DWebBrowser.cpp
  • Generals/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
  • Generals/Code/Main/RTS.RC
  • GeneralsMD/.gitignore
  • GeneralsMD/Code/GameEngine/CMakeLists.txt
  • GeneralsMD/Code/GameEngine/Include/Common/GameEngine.h
  • GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp
  • GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLadderScreen.cpp
  • GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLoginMenu.cpp
  • GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLWelcomeMenu.cpp
  • GeneralsMD/Code/GameEngineDevice/CMakeLists.txt
  • GeneralsMD/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DWebBrowser.h
  • GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DWebBrowser.cpp
  • GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
  • cmake/mingw.cmake
  • cmake/reactos-atl.cmake
  • cmake/widl.cmake
Files with no reviewable changes: 49

  • CMakeLists.txt
  • Core/.gitignore
  • Core/GameEngine/CMakeLists.txt
  • Core/GameEngine/Include/Common/INI.h
  • Core/GameEngine/Include/GameNetwork/WOLBrowser/FEBDispatch.h
  • Core/GameEngine/Include/GameNetwork/WOLBrowser/WebBrowser.h
  • Core/GameEngine/Source/Common/INI/INI.cpp
  • Core/GameEngine/Source/Common/INI/INIWebpageURL.cpp
  • Core/GameEngine/Source/Common/System/GameMemoryInitPools_Generals.inl
  • Core/GameEngine/Source/Common/System/GameMemoryInitPools_GeneralsMD.inl
  • Core/GameEngine/Source/GameNetwork/WOLBrowser/WebBrowser.cpp
  • Core/GameEngineDevice/CMakeLists.txt
  • Core/GameEngineDevice/Include/Win32Device/Common/Win32GameEngine.h
  • Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp
  • Core/Libraries/CMakeLists.txt
  • Core/Libraries/Source/EABrowserDispatch/BrowserDispatch.idl
  • Core/Libraries/Source/EABrowserDispatch/CMakeLists.txt
  • Core/Libraries/Source/EABrowserEngine/BrowserEngine.idl
  • Core/Libraries/Source/EABrowserEngine/CMakeLists.txt
  • Core/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
  • Core/Libraries/Source/WWVegas/WW3D2/dx8webbrowser.cpp
  • Core/Libraries/Source/WWVegas/WW3D2/dx8webbrowser.h
  • Core/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp
  • Dependencies/Utility/CMakeLists.txt
  • Dependencies/Utility/Utility/comsupp_compat.h
  • Generals/.gitignore
  • Generals/Code/GameEngine/CMakeLists.txt
  • Generals/Code/GameEngine/Include/Common/GameEngine.h
  • Generals/Code/GameEngine/Source/Common/GameEngine.cpp
  • Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLadderScreen.cpp
  • Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLWelcomeMenu.cpp
  • Generals/Code/GameEngineDevice/CMakeLists.txt
  • Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DWebBrowser.h
  • Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DWebBrowser.cpp
  • Generals/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
  • Generals/Code/Main/RTS.RC
  • GeneralsMD/.gitignore
  • GeneralsMD/Code/GameEngine/CMakeLists.txt
  • GeneralsMD/Code/GameEngine/Include/Common/GameEngine.h
  • GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp
  • GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLadderScreen.cpp
  • GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLWelcomeMenu.cpp
  • GeneralsMD/Code/GameEngineDevice/CMakeLists.txt
  • GeneralsMD/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DWebBrowser.h
  • GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DWebBrowser.cpp
  • GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
  • cmake/mingw.cmake
  • cmake/reactos-atl.cmake
  • cmake/widl.cmake

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable defects were found.

Summary

Removes the unused embedded browser from both games.

  • Both games stop running the unused embedded browser.
  • WOL menus keep showing the Terms of Service from a text file.
  • Browser-only INI and build support no longer ships with the games.

No actionable issues were found. Windows startup was not run during this review.

Reviews (1) · Last reviewed commit: "refactor: Remove the unused embedded web..." · Reviewed by Greptile

@OmarAglan OmarAglan changed the title refactor: Remove the unused embedded web browser refactor(EmbeddedBrowser)Remove the unused embedded web browser Nov 16, 2026
@OmarAglan OmarAglan changed the title refactor(EmbeddedBrowser)Remove the unused embedded web browser refactor(EmbeddedBrowser): Remove the unused embedded web browser Nov 16, 2026

@Skyaero42 Skyaero42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably used for ads and stuff
Nice cleanup

@xezon xezon added the Refactor Edits the code with insignificant behavior changes, is never user facing label Nov 17, 2026

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon changed the title refactor(EmbeddedBrowser): Remove the unused embedded web browser refactor: Remove legacy embedded web browser Nov 17, 2026
@xezon xezon changed the title refactor: Remove legacy embedded web browser refactor: Remove unused embedded web browser Nov 18, 2026
@xezon
xezon merged commit ee27e89 into TheSuperHackers:main Nov 18, 2026
31 checks passed
Ronnin2011 pushed a commit to Ronnin2011/GeneralsGameCode that referenced this pull request Nov 19, 2026
Upstream TheSuperHackers/GeneralsGameCode up to ee27e89 (19 commits, through TheSuperHackers#3691), with the DX9 side of
their changes:
- The embedded web browser removed (TheSuperHackers#3691): DX8WebBrowser's start-up, update, render and shutdown go, and with
  them dx8webbrowser.h, W3DWebBrowser.cpp in both trees and the core_browserengine link. Our edits there were
  d3d8 -> d3d9 includes only. Kept beside them: the RmlUi start-up in W3DDisplay::init, Begin_Scene's handling of
  an already-active scene (dx8wrapper.cpp), and WW3D2's d3d9 link.
- Dynamic vertices written through VertexFormatXYZNDUV2 fields (TheSuperHackers#3671), our dynamic buffer's own layout: the
  streak renderer takes upstream's writes with its UVs still mapped into the particle atlas cell (6bae419);
  seglinerenderer merged as upstream wrote it.
- max2w3d's libraries (TheSuperHackers#3679): upstream's list, d3d9 where it names d3d8lib - the fork has no d3d8lib target.
  The exporter is not built in this configuration.
- Taken as they are: Targa header validation (TheSuperHackers#3572 - every loose, repo and archived TGA the game loads passes
  it), Convert_Color without a reinterpret (TheSuperHackers#3655), shore waves restored when a saved game loads (TheSuperHackers#3493),
  RawFileClass::Raw_Seek returning the position again (TheSuperHackers#3679), the special-power fixes (TheSuperHackers#3666 - in this
  retail-compatible build only MissileLauncherBuildingUpdate's crash fix changes anything), map cache and path
  helpers (TheSuperHackers#3107, TheSuperHackers#3444), the MinGW CI job (TheSuperHackers#3552).
Checked before merging: the merged tree configured and built in a scratch worktree (z_generals Release, 0
errors); this commit's tree is that build's source. Six tools fail to build exactly as they do on main before
the merge (ParticleEditor, DebugWindow, WorldBuilder, wdump, W3DView, the old tree's WW3D2).

# Conflicts:
#	Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp
#	Core/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt
#	Core/Libraries/Source/WWVegas/WW3D2/dx8webbrowser.h
#	Core/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp
#	Core/Libraries/Source/WWVegas/WW3D2/streakRender.cpp
#	Core/Tools/WW3D/max2w3d/CMakeLists.txt
#	Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DWebBrowser.cpp
#	GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DWebBrowser.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants