Repository navigation
fix: accept ListTasks responses with fewer tasks than pageSize - #1273
Merged
Merged
Conversation
The A2A specification defines the response pageSize as the page size used for the response, and a server may return fewer tasks than that. ListTasksResult rejected any response where pageSize differed from the number of tasks, so clients failed with InvalidParamsError on every partial page. Fixes a2aproject#1260
Collaborator
|
Thank you @RaphaelFakhri ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ListTasksResultthrows when the responsepageSizediffers from the number of tasks intasks. The client transports build aListTasksResultfrom everyListTasksresponse, soClient.listTasks(...)fails withInvalidParamsErroron any page that is not full.The A2A specification allows this case. The request
pageSizeis the maximum number of tasks to return, and the service may return fewer. The responsepageSizeis "the page size used for this response". The List Tasks examples in the specification return"pageSize": 10with a single task, and the SDK rejects them.This change:
pageSize == tasks.size()check from theListTasksResultcompact constructor. The non-negative checks stay.pageSizeJavadoc to match the specification.JSONRPCUtilsTest.testListTasksResponse_PageSizeLargerThanReturnedTasks, which parses aListTasksJSON-RPC response withpageSize10 and one task.Server behavior does not change. The server-side task stores still set
pageSizeto the number of tasks they return.CONTRIBUTINGGuide.Fixes #1260