Skip to content

fix: accept ListTasks responses with fewer tasks than pageSize #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Nov 3, 2026
Merged

fix: accept ListTasks responses with fewer tasks than pageSize #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions jsonrpc-common/src/main/java/org/a2aproject/sdk/jsonrpc/common/wrappers/ListTasksResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @param tasks Array of tasks matching the specified criteria
* @param totalSize Total number of matching tasks across all pages, after any applicable authorization
* filtering
* @param pageSize Number of tasks returned in this response
* @param pageSize The page size used for this response; may be greater than the number of tasks returned
* @param nextPageToken Token for retrieving the next page of results (null if no more results)
*/
public record ListTasksResult(
Expand All @@ -39,9 +39,6 @@ public record ListTasksResult(
if (pageSize < 0) {
throw new IllegalArgumentException("pageSize must be non-negative");
}
if (pageSize != tasks.size()) {
throw new IllegalArgumentException("pageSize must be equal to the number of tasks in the list. Got " + pageSize + ", but list has " + tasks.size() + " tasks.");
}
// Make defensive copy
tasks = List.copyOf(tasks);
}
Expand Down
33 changes: 33 additions & 0 deletions spec-grpc/src/test/java/org/a2aproject/sdk/grpc/utils/JSONRPCUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
import org.a2aproject.sdk.jsonrpc.common.wrappers.GetTaskPushNotificationConfigResponse;
import org.a2aproject.sdk.jsonrpc.common.wrappers.GetTaskResponse;
import org.a2aproject.sdk.jsonrpc.common.wrappers.ListTasksRequest;
import org.a2aproject.sdk.jsonrpc.common.wrappers.ListTasksResponse;
import org.a2aproject.sdk.jsonrpc.common.wrappers.ListTasksResult;
import org.a2aproject.sdk.jsonrpc.common.wrappers.SendMessageRequest;
import org.a2aproject.sdk.spec.DataPart;
import org.a2aproject.sdk.spec.InvalidParamsError;
Expand Down Expand Up @@ -142,6 +144,37 @@ public void testGetTask_WithNestedNulls_RoundTrips() throws JsonProcessingExcept
assertEquals(task, roundTripped.getResult());
}

@Test
public void testListTasksResponse_PageSizeLargerThanReturnedTasks() throws JsonProcessingException {
String json = """
{
"jsonrpc": "2.0",
"id": "1",
"result": {
"tasks": [{
"id": "task-1",
"contextId": "context-1",
"status": {
"state": "TASK_STATE_COMPLETED"
}
}],
"nextPageToken": "",
"pageSize": 10,
"totalSize": 1
}
}
""";

ListTasksResponse response = assertInstanceOf(ListTasksResponse.class,
JSONRPCUtils.parseResponseBody(json, LIST_TASK_METHOD));
ListTasksResult result = response.getResult();
assertNotNull(result);
assertEquals(1, result.tasks().size());
assertEquals(10, result.pageSize());
assertEquals(1, result.totalSize());
assertFalse(result.hasMoreResults());
}

@Test
public void testParseCreateTaskPushNotificationConfigRequest_ValidProtoFormat() throws JsonProcessingException {
String validRequest = """
Expand Down
Loading