Repository navigation
ja: mark the checked general.yaml strings as verified - #962
Merged
Merged
Conversation
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks 57 of the 92 unverified strings in the Japanese SharedRules/general.yaml as verified (t: to T:), as #954 did for default.yaml. SimpleSpeak read the kind of interval in English ("open interval から c に d"), so it now says 開区間, 閉区間, 左開右閉区間 or 左閉右開区間 followed by "c から d まで", and the rule has an audit-ignore note because it no longer speaks the tag name as en does. The repeating digits of a decimal are now 循環節, the dictionary term, instead of the word-for-word 数字を繰り返して, and Cov is 共分散 instead of the katakana コーブ and コバリアンス. The other 35 strings stay t:: the matrix and chemistry phrases need word-order changes that I would like to send as separate PRs, and I have no source for 主値ログ yet. All three fixes have tests, all language tests pass, and audit-translations ja goes from 3212 to 3159 untranslated strings with rule differences still at 30.