Repository navigation
chore(deps): bump x/net to 0.62.0 for the two html-parser advisories - #312
Merged
Merged
Conversation
Clears the only actionable finding out of the 48 open code-scanning alerts.
golang.org/x/net v0.61.0 -> v0.62.0 (indirect)
v0.61.0 arrived with the weekly group bump and carries two advisories in
`x/net/html`, both fixed in 0.62.0:
CVE-2026-78661 coalescing adjacent text nodes in addText/fosterParent
CVE-2026-97045 childTextNodesAreLiteral stops walking up the tree
Neither is reachable here: `go list -deps ./...` shows `golang.org/x/net/html`
is not in the build graph at all, which is also why `govulncheck` reported 0
affected both before and after. Trivy flags the module version rather than the
imported package, so the alerts were real as reported and are worth clearing
rather than dismissing -- a one-line indirect bump is cheaper than carrying two
permanent exceptions, and the next person reading the alert list should not have
to re-derive that the package is unused.
Verified: `go build ./...`, `go vet ./...` and `go test ./...` all pass (0
failures); `govulncheck` 0 affected; `trivy fs` on `server/go.mod` drops from 3
findings to 1.
That remaining one is GO-2026-5932 -- `golang.org/x/crypto/openpgp` is
unmaintained -- and it is deliberately left alone in both modules. Its only
"fix" is the pseudo-version 0.58.1-0.20261009181718-2f1f834330b2, and trading a
tagged release for an untagged commit is a worse trade than the finding: the
openpgp package is likewise absent from both build graphs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the only actionable finding out of the 48 open code-scanning alerts.
v0.61.0 arrived with the weekly group bump (#300) and carries two advisories in
x/net/html, both fixed in 0.62.0:addText/fosterParentchildTextNodesAreLiteralstops walking up the treeNeither is reachable here —
go list -deps ./...showsgolang.org/x/net/htmlis not in the build graph at all, which is also whygovulncheckreported 0 affected both before and after. Trivy flags the module version rather than the imported package, so the alerts were accurate as reported and worth clearing rather than dismissing: a one-line indirect bump is cheaper than two permanent exceptions, and the next person reading the alert list should not have to re-derive that the package is unused.Verification
go build ./...,go vet ./...,go test ./...— all pass, 0 failures.govulncheck— 0 affected.trivy fsonserver/go.mod— 3 findings → 1.The one left behind, deliberately
GO-2026-5932—golang.org/x/crypto/openpgpis unmaintained. Its only "fix" is the pseudo-version0.58.1-0.20261009181718-2f1f834330b2, and trading a tagged release for an untagged commit is a worse deal than the finding itself. The openpgp package is likewise absent from both build graphs. It stays inserver/go.modandcli/go.modas the single remaining UNKNOWN-severity note in each.🤖 Generated with Claude Code