Repository navigation
feat(mvm): updates and day-2 operations - #15
Merged
Merged
Conversation
ma-hartma
marked this pull request as draft
September 24, 2026 13:49
ma-hartma
force-pushed
the
vm-updates
branch
from
September 28, 2026 12:59
2370d5e to
1782f4c
Compare
vknabel
removed their request for review
November 9, 2026 13:48
ma-hartma
commented
Nov 18, 2026
ma-hartma
force-pushed
the
vm-updates
branch
from
November 18, 2026 10:59
92c1435 to
d5fb006
Compare
ma-hartma
marked this pull request as ready for review
November 18, 2026 13:17
ma-hartma
requested review from
Pilzington and
vknabel
and removed request for
vknabel
November 18, 2026 13:17
ma-hartma
force-pushed
the
vm-updates
branch
from
November 18, 2026 13:21
ab62174 to
252725f
Compare
ma-hartma
force-pushed
the
vm-updates
branch
from
November 18, 2026 13:23
252725f to
7ba27a9
Compare
Contributor
Author
|
@Pilzington @ostempel - feel free to merge the stages into this PR once you have reviewed. #57 |
Merged
ma-hartma
force-pushed
the
vm-updates
branch
from
November 19, 2026 10:42
a756843 to
2892ff0
Compare
vknabel
reviewed
Nov 19, 2026
Pilzington
reviewed
Nov 19, 2026
vknabel
approved these changes
Nov 20, 2026
Contributor
Author
|
Let's please add #50 on top of this before merging. |
* chore(mvm): units in field names * chore(mvm): match validations with upstream * chore(mvm): consistent usage of snake_case * chore(mvm): consistent validations and tests * chore(mvm): order_reference instead of order_number * fix(mvm): availability and service_class must not be empty * feat(mvm): extension points for backup and encryption * review(mvm): stricter fqdn validation * review(mvm): drive letter validation different for inputs * review(mvm): rename disk label to name to be less confusing * chore(mvm): cleanup comment
Pilzington
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces updates and day-2 operations to MVMs.
As the upstream API's update operations currently cannot all run in parallel, there is a separate update method for ServiceClass updates, which will be included into the update operation once supported.
Also, the MVM move command could later be replaced with a location_uuid parameter in the update operation.