Repository navigation
chore: cleanup and unify - #50
Merged
Merged
Conversation
ma-hartma
marked this pull request as ready for review
November 13, 2026 14:06
ma-hartma
commented
Nov 17, 2026
ma-hartma
commented
Nov 17, 2026
ma-hartma
commented
Nov 17, 2026
Contributor
Author
|
Needs to be overhauled after #15 |
ma-hartma
force-pushed
the
api-cleanup
branch
from
November 19, 2026 16:45
068e6f8 to
c060d88
Compare
Contributor
Author
|
@vknabel and @Pilzington this can go into #15. |
vknabel
reviewed
Nov 20, 2026
Pilzington
reviewed
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR streamlines the API to match best practices and our WIP API guidelines better:
Changes
JSON and client field names:
Required fields: initial_ip_address on create, size_gb on disks, and the contact phone.
Stricter validation:
Moved rules: is_name_code moved from fits.api.v1 to fits.api.mvm.v1, and the shared macaddress extension is now mac_address. The published JS and Python packages export these under the new names.
Used AI-Tools ✨
References: