Repository navigation
Review Link Pilot - #1265
Merged
Merged
Review Link Pilot#1265
Conversation
Contributor
There was a problem hiding this comment.
Link Pilot is approved and merged, @xzthemeofsss. I completed the pinned registry record and removed the intake file, preserving your English and Chinese listing text, icon and three settings images. Nothing is needed from you; the listing is awaiting the registry publish workflow.
Review data
- Policy: main
REVIEW.mdblob8da1286fd8870c87ff53767e8644858627b7371f. Reviewed registry head9ab61ba7ec6ca1d01b2f361260f14e5d5b51ce3d. Read the PR, submission #1264 and all current discussion; submission author, repository owner and package attribution agree. - Artifact: Git
https://github.com/xzthemeofsss/paseo-plugins.git, exact requested commitef46ba62a203c89c0d160551a98008d32fed9d07, directoryplugins/link-pilot, version0.1.0. Fetched without hooks or submodules; checked all 36 archive entries for safe paths and regular-file/directory types before extraction. Review archive SHA-256:2c02ad9f3cee692842378eb0188d36b971cdd4b022c5d27ecf9948681574c351. No tag is recorded. - Inspected both runtime entries, every production client/shared module, local imports, manifest/package/lock, development script entrypoints, README, English and Chinese overviews and listing assets. No manifest preparation, lifecycle hook or installed runtime dependency tree. Runtime libraries are host-provided; the development lock fixes 428 packages to integrity-bearing npm-registry sources. Development esbuild/fsevents install scripts and the probe's VM evaluation are not invoked by installation or activation. No plugin or dependency code was installed, built, imported or executed.
- Click handling:
client/web.tsaccepts visible assistant HTTP(S) anchors, excludes download links and unrelated gestures, and verifies source pane/agent context throughclient/host.ts. It reads current plugin host preferences, rechecks workspace context and calls the selected browser API. Same-origin script fetches locate checked existing app modules; fetched text is parsed for identifiers, not evaluated. Only the desktop adapter attaches the click listener; unavailable adapters retain native handling. After interception, errors show a dismissible message rather than opening another destination. Private app-interface compatibility and the one-host-per-app constraint are disclosed in both overviews. - Access/execution: preferences persist through public settings APIs. The client reads clicked URLs/labels and workspace, pane and agent context; the chosen browser contacts the selected URL. No independent telemetry/backend, credential or other-plugin storage read, direct filesystem mutation, subprocess, shell, runtime installer or model-provider request was found in the production scope. Existing app-module execution serves browser placement; it does not load code from the clicked destination into the plugin.
- Registry edits: exact pin/path, utils category, submitter and issue timestamp; removed
submissions/1264.json. No redundant overview or description overrides. Viewed all three images; icon and image URLs return PNG bytes identical to the pinned tree. Both default and translated listing content meet the current policy. - Trusted-main online validation passes: 393 well-formed records, one changed record matching its artifact. Exact-head Validate CI passed. Static inspection only; author-reported integration/UI checks were not rerun, and desktop/platform compatibility and unchanged host-library implementations were not independently tested. No concrete serious safety finding or factory-policy incompatibility identified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1264. Submitted by @xzthemeofsss.
Ready for artifact review. The reviewer will resolve the submitted source and complete the registry listing.
Submission:
submissions/1264.json.Git references are optional. Use a supplied reference; otherwise resolve main during review. Git updates are submitted manually.