Skip to content

chore(deps): update dependency ubuntu to v26 - #21

Open
mailerlite-renovate[bot] wants to merge 1 commit into
mainfrom
renovate/ubuntu-26.x
Open

mailerlite-renovate[bot] wants to merge 1 commit into
mainfrom
renovate/ubuntu-26.x

Conversation

@mailerlite-renovate

Copy link
Copy Markdown

This PR contains the following updates:

Package Type Update Change
ubuntu github-runner major 24.04 → 26.04

Configuration

📅 Schedule: (in timezone UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@mailerlite-kritika

mailerlite-kritika Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Re-runViewConfidence Score: 3/5

[Medium risk] The reported P1 stands: runs-on moves to ubuntu-26.04 while matrix.operating-system stays ubuntu-24.04, so the Java 11, 17 and 21 job names misstate the runner image. The review did not check whether the ubuntu-26.04 label is available on GitHub-hosted runners, which the diff and description do not show. The risk is medium because it is a major runner-image step confined to one test workflow that a revert undoes quickly.

Findings

Summary

Bumps the test job's runner from ubuntu-24.04 to ubuntu-26.04

Renovate changed only the hard-coded runs-on in .github/workflows/test.yml. The matrix.operating-system value stays ubuntu-24.04, and the job name uses it. After merge, the three Java jobs (11, 17, 21) run on the 26.04 image but are labelled as 24.04.

Review context · 0/6 commands
  • Commands run: none

Reviews (1) · Last reviewed commit: "chore(deps): update dependency ubuntu to..." · claude-sonnet-5-5

run:

runs-on: ubuntu-24.04
runs-on: ubuntu-26.04

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Job name still says ubuntu-24.04 but job runs on 26.04 · correctness

This applies to every run of the workflow. runs-on is hard-coded and does not read matrix.operating-system. That matrix value stays ubuntu-24.04 and appears only in the job name (Java X Test on ubuntu-24.04). After this bump the jobs run on ubuntu-26.04 but are labelled as 24.04. Any required-status-check names that match the old label would also be misleading. The matrix and runs-on are meant to be one setting. Renovate updated only one of them.

Suggested fix

Drive runs-on from the matrix and bump the matrix value:

    runs-on: ${{ matrix.operating-system }}
    strategy:
      matrix:
        operating-system: [ubuntu-26.04]
Prompt for a coding agent
In .github/workflows/test.yml, change line 12 `runs-on: ubuntu-26.04` to `runs-on: ${{ matrix.operating-system }}`, and change the matrix entry on line 15 from `operating-system: [ubuntu-24.04]` to `operating-system: [ubuntu-26.04]`, so the job name matches the runner actually used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants