Skip to content

chore(deps): update dependency ubuntu to v26 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mailerlite-renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency ubuntu to v26 #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
run:

runs-on: ubuntu-24.04
runs-on: ubuntu-26.04

@mailerlite-kritika mailerlite-kritika Bot Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Job name still says ubuntu-24.04 but job runs on 26.04 · correctness

This applies to every run of the workflow. runs-on is hard-coded and does not read matrix.operating-system. That matrix value stays ubuntu-24.04 and appears only in the job name (Java X Test on ubuntu-24.04). After this bump the jobs run on ubuntu-26.04 but are labelled as 24.04. Any required-status-check names that match the old label would also be misleading. The matrix and runs-on are meant to be one setting. Renovate updated only one of them.

Suggested fix

Drive runs-on from the matrix and bump the matrix value:

    runs-on: ${{ matrix.operating-system }}
    strategy:
      matrix:
        operating-system: [ubuntu-26.04]
Prompt for a coding agent 
In .github/workflows/test.yml, change line 12 `runs-on: ubuntu-26.04` to `runs-on: ${{ matrix.operating-system }}`, and change the matrix entry on line 15 from `operating-system: [ubuntu-24.04]` to `operating-system: [ubuntu-26.04]`, so the job name matches the runner actually used.

strategy:
matrix:
operating-system: [ubuntu-24.04]
Expand Down