Repository navigation
fix: restore menu list keyboard navigation after reconnect - #36871
Open
aseeb shibin (asxxb) wants to merge 2 commits into
Open
aseeb shibin (asxxb) wants to merge 2 commits into
aseeb shibin (asxxb) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
aseeb shibin (@asxxb) Please run |
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Author
Hi! I've added the required Beachball change file and pushed the update. The |
Zacky Ma (marchbox)
approved these changes
Oct 14, 2026
Zacky Ma (marchbox)
approved these changes
Oct 14, 2026
aseeb shibin (asxxb)
force-pushed
the
fix/menu-list-focusgroup-reconnect
branch
from
October 24, 2026 19:48
c970609 to
5a54f76
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When a
fluent-menu-listelement was removed from the DOM and reinserted, itsFocusGroupinstance remained referenced after being disconnected. As a result, arrow-key navigation could stop working in Firefox and Safari.New Behavior
Clear the existing
FocusGroupreference whenMenuListdisconnects, allowing a new instance to be created when the element reconnects.Add a regression test to verify that arrow-key navigation continues working after the menu list is moved in the DOM.
Related Issue(s)