Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "patch",
"comment": "fix: restore menu list keyboard navigation after reconnect",
"packageName": "@fluentui/web-components",
"email": "aseebshibin4@gmail.com"
}
30 changes: 30 additions & 0 deletions packages/web-components/src/menu-list/menu-list.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,36 @@ test.describe('MenuList', () => {
await expect(firstItem).toBeFocused();
Comment thread
asxxb marked this conversation as resolved.
});

test('should preserve arrow key navigation after being moved in the DOM', async ({ fastPage }) => {
const { element } = fastPage;
const menuItems = element.locator(MenuItemTagName);

await fastPage.setTemplate();

// Move the menu list to trigger its disconnect/reconnect lifecycle.
await element.evaluate(node => {
const parent = node.parentElement;

if (!parent) {
throw new Error('Menu list must have a parent element');
}

const nextSibling = node.nextSibling;
node.remove();
parent.insertBefore(node, nextSibling);
});

await element.evaluate(node => {
node.focus();
});

await expect(menuItems.first()).toBeFocused();

await element.press('ArrowDown');

await expect(menuItems.nth(1)).toBeFocused();
});

test('should focus before the queued item refresh completes', async ({ fastPage, page }) => {
await fastPage.setTemplate('');
await page.evaluate(
Expand Down
1 change: 1 addition & 0 deletions packages/web-components/src/menu-list/menu-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export class MenuList extends BaseMenuList {

disconnectedCallback() {
this.fg?.disconnect();
this.fg = undefined;
super.disconnectedCallback();
}

Expand Down
Loading