Repository navigation
feat(settings): rework keyboard sub menu when no keyboard is installed (#753) - #755
Merged
andrewtavis merged 2 commits intoNov 7, 2026
Conversation
…ard is installed (scribe-org#753) Signed-off-by: prince-0408 <66916296+prince-0408@users.noreply.github.com>
andrewtavis
approved these changes
Nov 7, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: This is some great user experience here, @prince-0408! Thanks for the quick work on these PRs! 🚀
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR reworks the keyboard sub menu in the Settings screen when no keyboard is currently installed, aligning it with the download UI empty state and the Figma design.
Summary of Changes:
SettingsScreen.kt:EmptyKeyboardSettingsSection.i18n_app_settings_keyboard_title).i18n_app_download_menu_ui_no_keyboards_installed).MaterialTheme.colorScheme.onSurface(pure#FFFFFFin dark mode) for crisp, bright readability matching the Figma designs.Install keyboardsbutton directly beneath the card.SettingsScreenInstallKeyboardButtonTest.kt:keyboardTitle_isDisplayed_whenKeyboardNotInstalledto ensure the header is visible when no keyboard is installed.noKeyboardsMessage_isDisplayed_whenKeyboardNotInstalledto verify the instruction card renders when no keyboard is installed.noKeyboardsMessage_isNotDisplayed_whenKeyboardInstalledto verify the instruction card is hidden once keyboards are present.CHANGELOG.md:### 🎨 Design.UI Preview
Related issue