Skip to content

feat(settings): rework keyboard sub menu when no keyboard is installed (#753) - #755

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
prince-0408:feature/rework-keyboard-sub-menu-753
Nov 7, 2026
Merged

andrewtavis merged 2 commits into
scribe-org:mainfrom
prince-0408:feature/rework-keyboard-sub-menu-753

Conversation

@prince-0408

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

This PR reworks the keyboard sub menu in the Settings screen when no keyboard is currently installed, aligning it with the download UI empty state and the Figma design.

Summary of Changes:

  1. SettingsScreen.kt:

    • Replaced the standalone floating "Install keyboards" button with EmptyKeyboardSettingsSection.
    • Displays the section title "Select installed keyboard" (i18n_app_settings_keyboard_title).
    • Displays a rounded surface card with the instruction text (i18n_app_download_menu_ui_no_keyboards_installed).
    • Used MaterialTheme.colorScheme.onSurface (pure #FFFFFF in dark mode) for crisp, bright readability matching the Figma designs.
    • Places the Install keyboards button directly beneath the card.
  2. SettingsScreenInstallKeyboardButtonTest.kt:

    • Added keyboardTitle_isDisplayed_whenKeyboardNotInstalled to ensure the header is visible when no keyboard is installed.
    • Added noKeyboardsMessage_isDisplayed_whenKeyboardNotInstalled to verify the instruction card renders when no keyboard is installed.
    • Added noKeyboardsMessage_isNotDisplayed_whenKeyboardInstalled to verify the instruction card is hidden once keyboards are present.
  3. CHANGELOG.md:

    • Documented the change under ### 🎨 Design.

UI Preview

Settings UI with no keyboards installed

Related issue

…ard is installed (scribe-org#753)

Signed-off-by: prince-0408 <66916296+prince-0408@users.noreply.github.com>

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This is some great user experience here, @prince-0408! Thanks for the quick work on these PRs! 🚀

@andrewtavis
andrewtavis merged commit 5a881a5 into scribe-org:main Nov 7, 2026
7 checks passed

@ashb155 ashb155 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @prince-0408 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework keyboard sub menu display to user when there's no keyboard installed

3 participants