Repository navigation
Update sub-menu settings options to include their current value (#751) - #756
Merged
andrewtavis merged 2 commits intoNov 7, 2026
Merged
Conversation
Collaborator
|
i guess few of the tests are failing, could you have a look @prince-0408 |
andrewtavis
approved these changes
Nov 7, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: All of this is looking great, @prince-0408! Thanks for the quick work here!
ashb155
approved these changes
Nov 7, 2026
Collaborator
There was a problem hiding this comment.
LGTM as well @prince-0408 ! Thanks for all the work here!
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR updates the keyboard settings sub-menu options in
LanguageSettingsScreento display their current values next to the navigation chevron, aligning the UI with Figma designs.Summary of Changes:
ScribeItem.kt&ClickableItemComp.kt:val value: String? = nullparameter toScribeItem.ClickableItem.ClickableItemCompto rendervalueinMaterialTheme.colorScheme.onSurfaceVariant(styletypography.bodyMedium) positioned directly before the right navigation chevron icon.item.valuethroughItemsCardContainer.ScribeLanguage.kt&PreferencesHelper.kt:defaultLayoutproperty toScribeLanguagerepresenting each language's default layout ("QWERTY","AZERTY","QWERTZ","ЙЦУКЕН").PreferencesHelper.getDefaultKeyboardLayout(context, language)andPreferencesHelper.setDefaultKeyboardLayout(context, language, layout)using language-specific preference keys with fallback toScribeLanguage.defaultLayout.LanguageSettingsScreen.kt:translationSourceLanguage,defaultLayout, anddefaultCurrencySymbol.DisposableEffectwithLifecycleEventObserverlistening toLifecycle.Event.ON_RESUMEso displayed values update immediately when returning from sub-screens.valueon "Select language", "Default keyboard", and "Default currency symbol" menu items.Tests & Documentation:
ScribeLanguageTestverifying default layout resolution across all languages.PreferencesHelperTestcase verifying language-specific preference keys.displaysClickableItemWithValueinScribeItemListTest.CHANGELOG.mdunder### 🎨 Design.UI Preview
Related issue