Skip to content

🐛 fix(test): dup2 a descriptor above 63 on GraalPy - #942

Merged
gaborbernat merged 1 commit into
mainfrom
fix/descriptor-test-dup2
Nov 16, 2026
Merged

gaborbernat merged 1 commit into
mainfrom
fix/descriptor-test-dup2

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The weekly GraalPy job failed on a test that duplicates a descriptor above 63, because the test called fcntl.fcntl, which GraalPy 25.4.4 does not provide (its fcntl module defines only flock, lockf and ioctl; failing run). The case, added in #938, checks a descriptor past NetBSD's static /dev/fd nodes. The test now uses os.dup2, which places the duplicate on the same slot on every platform, so the case is checked on GraalPy too. The test now first requires descriptor 100 to be free, because os.dup2 silently closes whatever holds it.

🧪 filelock users see no difference.

@gaborbernat gaborbernat added the skip news Internal change; exempt from the news fragment check label Nov 16, 2026
GraalPy 25.4.4 has no fcntl.fcntl, so the test that duplicates a descriptor
above 63 failed there. os.dup2 gives the same slot on every platform. The test
first checks slot 100 is free, since dup2 would silently close a descriptor
already holding it. The fcntl gate goes; the fd-directory gate stays, because
descriptors_on needs a descriptor view to count with.
@gaborbernat
gaborbernat force-pushed the fix/descriptor-test-dup2 branch from 2b2e388 to da0f029 Compare November 16, 2026 17:34
@gaborbernat
gaborbernat merged commit 15f6832 into main Nov 16, 2026
48 checks passed
@gaborbernat
gaborbernat deleted the fix/descriptor-test-dup2 branch November 16, 2026 17:46
@gaborbernat gaborbernat changed the title 🧪 test: dup2 the above-63 descriptor on GraalPy 🐛 fix(test): dup2 a descriptor above 63 on GraalPy Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug skip news Internal change; exempt from the news fragment check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant