Repository navigation
Remove DSTACK_ROUTER_INTERNAL_IP - #4473
Merged
Merged
Conversation
The variable predates replica IP interpolation and is replaced by
${{ groups[i].replicas[j].IP_ADDRESS }}. Dynamo workers no longer wait
for the router replica's internal IP, and their provisioning no longer
loads every replica of the run.
un-def
added a commit
that referenced
this pull request
Nov 10, 2026
Retry was rejected because workers got the router's internal IP once, via DSTACK_ROUTER_INTERNAL_IP, and a retried router could come back at a different address. Since #4402, Dynamo services run etcd in a dedicated group referenced via replica IP interpolation (#4177), and #4473 removed the variable, so nothing depends on the router's address anymore.
un-def
added a commit
that referenced
this pull request
Nov 10, 2026
The check rejected changes that would roll the router or change the router type, since workers got the router's internal IP only once. DSTACK_ROUTER_INTERNAL_IP was removed in #4473, so Dynamo services can now be updated like any other service. Router type changes are allowed too: only the SMG worker sync reads the type, and it follows the new spec. Mid-rollout errors are expected, as old and new routers and workers are incompatible, but the error window is no worse than with stopping and re-applying. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable predates replica IP interpolation and is replaced by ${{ groups[i].replicas[j].IP_ADDRESS }}. Dynamo workers no longer wait for the router replica's internal IP, and their provisioning no longer loads every replica of the run.