Skip to content

Remove DSTACK_ROUTER_INTERNAL_IP - #4473

Merged
un-def merged 1 commit into
masterfrom
pr_remove_dstack_router_internal_ip_var
Nov 9, 2026
Merged

un-def merged 1 commit into
masterfrom
pr_remove_dstack_router_internal_ip_var

Conversation

@un-def

@un-def un-def commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

The variable predates replica IP interpolation and is replaced by ${{ groups[i].replicas[j].IP_ADDRESS }}. Dynamo workers no longer wait for the router replica's internal IP, and their provisioning no longer loads every replica of the run.

The variable predates replica IP interpolation and is replaced by
${{ groups[i].replicas[j].IP_ADDRESS }}. Dynamo workers no longer wait
for the router replica's internal IP, and their provisioning no longer
loads every replica of the run.
@un-def
un-def merged commit 6d70e58 into master Nov 9, 2026
26 checks passed
@un-def
un-def deleted the pr_remove_dstack_router_internal_ip_var branch November 9, 2026 13:59
un-def added a commit that referenced this pull request Nov 10, 2026
Retry was rejected because workers got the router's internal IP once,
via DSTACK_ROUTER_INTERNAL_IP, and a retried router could come back at
a different address. Since #4402, Dynamo services run etcd in a
dedicated group referenced via replica IP interpolation (#4177), and
#4473 removed the variable, so nothing depends on the router's address
anymore.
un-def added a commit that referenced this pull request Nov 10, 2026
The check rejected changes that would roll the router or change the
router type, since workers got the router's internal IP only once.
DSTACK_ROUTER_INTERNAL_IP was removed in #4473, so Dynamo services can
now be updated like any other service.

Router type changes are allowed too: only the SMG worker sync reads
the type, and it follows the new spec. Mid-rollout errors are
expected, as old and new routers and workers are incompatible, but
the error window is no worse than with stopping and re-applying.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant